squito commented on a change in pull request #24892: [SPARK-25341][Core]
Support rolling back a shuffle map stage and re-generate the shuffle files
URL: https://github.com/apache/spark/pull/24892#discussion_r311164837
##########
File path: core/src/main/scala/org/apache/spark/scheduler/ShuffleMapStage.scala
##########
@@ -87,7 +87,10 @@ private[spark] class ShuffleMapStage(
*/
def isAvailable: Boolean = numAvailableOutputs == numPartitions
- /** Returns the sequence of partition ids that are missing (i.e. needs to be
computed). */
+ /**
+ * Returns the sequence of partition ids that are missing (i.e. needs to be
computed).
+ * If the current stage is indeterminate, missing partition is all
partitions every time.
Review comment:
this is true in the places where this method happens to be called, but its a
little misleading -- if you called it in the middle of a normal run of a stage,
it would tell you what was left. I think its better to not put this comment in
as it could be wrong in the future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
