HyukjinKwon commented on a change in pull request #25334:
[SPARK-28598][SQL][WIP] Few date time manipulation functions does not provide
versions supporting Column as input through the Dataframe API
URL: https://github.com/apache/spark/pull/25334#discussion_r311339226
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/DateFunctionsSuite.scala
##########
@@ -239,6 +239,21 @@ class DateFunctionsSuite extends QueryTest with
SharedSQLContext {
df.select(date_add(col("ss"), 7)),
Seq(Row(Date.valueOf("2015-06-08")), Row(Date.valueOf("2015-06-09"))))
+ val df2 = df.withColumn("x", lit(1))
+ checkAnswer(
+ df2.select(date_add(col("d"), col("x"))),
Review comment:
@WeichenXu123, I think we only need one test that calls `Column` since
that's what this Pr changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
