advancedxy commented on a change in pull request #25306: [SPARK-28573][SQL]
Convert InsertIntoTable(HiveTableRelation) to DataSource inserting for
partitioned table
URL: https://github.com/apache/spark/pull/25306#discussion_r311375710
##########
File path:
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveParquetMetastoreSuite.scala
##########
@@ -512,16 +512,14 @@ class HiveParquetMetastoreSuite extends
ParquetPartitioningTest {
|PARTITION (`date`='2015-04-01')
|select a, b from jt
""".stripMargin)
- // Right now, insert into a partitioned Parquet is not supported in data
source Parquet.
- // So, we expect it is not cached.
- assert(getCachedDataSourceTable(tableIdentifier) === null)
+ checkCached(tableIdentifier)
Review comment:
I will check existing tests. ORC cases are not that much probably, I will
add similar cases for ORC then.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
