yeshengm commented on a change in pull request #24749: [SPARK-27890][SQL]
Improve SQL parser error message for character-only identifier with hyphens
except those in expressions
URL: https://github.com/apache/spark/pull/24749#discussion_r311393205
##########
File path:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4
##########
@@ -609,19 +612,19 @@ rowFormat
;
multipartIdentifier
- : parts+=identifier ('.' parts+=identifier)*
+ : parts+=errorCapturingIdentifier ('.' parts+=errorCapturingIdentifier)*
;
tableIdentifier
- : (db=identifier '.')? table=identifier
+ : (db=errorCapturingIdentifier '.')? table=errorCapturingIdentifier
;
functionIdentifier
- : (db=identifier '.')? function=identifier
+ : (db=errorCapturingIdentifier '.')? function=errorCapturingIdentifier
;
namedExpression
- : expression (AS? (identifier | identifierList))?
+ : expression (AS? (name=errorCapturingIdentifier | identifierList))?
Review comment:
I just tried on Postgres, and it's a syntax error.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
