dongjoon-hyun commented on a change in pull request #25357: 
[SPARK-28617][SQL][TEST] Fix misplacement when comment is at the end of the 
query
URL: https://github.com/apache/spark/pull/25357#discussion_r311405432
 
 

 ##########
 File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala
 ##########
 @@ -229,6 +229,8 @@ class SQLQueryTestSuite extends QueryTest with 
SharedSQLContext {
     // List of SQL queries to run
 
 Review comment:
   Shall you change line 227 together in this PR in order to remove the 
comment-only lines? It will remove 41 lines additionally.
   ```scala
   -    val (comments, code) = input.split("\n").partition(_.startsWith("--"))
   +    val (comments, code) = 
input.split("\n").partition(_.trim.startsWith("--"))
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to