wangyum commented on a change in pull request #25375: [SPARK-28642][SQL] Hide 
credentials in show create table
URL: https://github.com/apache/spark/pull/25375#discussion_r311550951
 
 

 ##########
 File path: 
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala
 ##########
 @@ -1099,7 +1100,7 @@ case class ShowCreateTableCommand(table: 
TableIdentifier) extends RunnableComman
   private def showDataSourceTableOptions(metadata: CatalogTable, builder: 
StringBuilder): Unit = {
     builder ++= s"USING ${metadata.provider.get}\n"
 
-    val dataSourceOptions = metadata.storage.properties.map {
+    val dataSourceOptions = Utils.redact(metadata.storage.properties).map {
 
 Review comment:
   `Utils.redact` or `CatalogUtils.maskCredentials`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to