xuanyuanking commented on a change in pull request #24892: [SPARK-25341][Core] 
Support rolling back a shuffle map stage and re-generate the shuffle files
URL: https://github.com/apache/spark/pull/24892#discussion_r311559296
 
 

 ##########
 File path: 
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/BlockStoreClient.java
 ##########
 @@ -49,12 +50,24 @@ public abstract void fetchBlocks(
       String host,
       int port,
       String execId,
+      int shuffleGenerationId,
 
 Review comment:
   Yep, after the refactor e7365e3, finally, we can rename the method and split 
shuffle fetch and data fetch into 2 separated function, thanks for your 
guidance and advice!
   Done in 67f70a4.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to