srowen commented on issue #25335: [SPARK-28601][CORE][SQL] Use StandardCharsets.UTF_8 instead of "UTF-8" string representation, and get rid of UnsupportedEncodingException URL: https://github.com/apache/spark/pull/25335#issuecomment-519103683 You raise a good point about not being able to get review attention sometimes @HeartSaVioR . Sometimes something isn't reviewed or merged because it's not obviously wrong, just not obviously worth it or important. That's a soft 'no' and I'd prefer to be more explicit about it, but sometimes that isn't received well. Sometimes it's just that nobody has picked up that particular change to look at in the long stream of new issues each day, or the right person hasn't seen it. For example I honestly ignore SQL changes and focus on ML, core, docs, small changes. We want people to ping when they honestly think it's an important change. Sometimes people ping too much ahead of their judgment, but that is not your case. My advice is always to use git 'blame' or Github to figure out who has been working on the code being changed and ping them. Sometimes Github's suggested reviewers are useful. You can ping me on PRs you think are not getting reviewed and I'll review, and if I feel qualified and it's ready, can merge.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
