squito commented on issue #25229: [SPARK-27900][K8s] Add jvm oom flag
URL: https://github.com/apache/spark/pull/25229#issuecomment-519186339
 
 
   ok sorry I refreshed my memory a bit more -- I think I lean towards 
including this by default.  Yes, the user could do it themselves, but they are 
likely to forget, and the cases where they don't want it are very few.
   
   I agree with dongjoon, though, that this seems uglier than necessary -- 
probably easier if we add an option to change it for all cluster managers, and 
then handle it in `SparkSubmitCommandBuilder` around here: 
https://github.com/apache/spark/blob/a59fdc4b5783be591a236bfc60d1107caa818412/launcher/src/main/java/org/apache/spark/launcher/SparkSubmitCommandBuilder.java#L268-L273

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to