srowen commented on a change in pull request #25331: [SPARK-27768][SQL]
Infinity, -Infinity, NaN should be recognized in a case insensitive manner.
URL: https://github.com/apache/spark/pull/25331#discussion_r311719560
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
##########
@@ -191,6 +191,31 @@ object Cast {
}
def resolvableNullability(from: Boolean, to: Boolean): Boolean = !from || to
+
+ def processFloatingPointSpecialLiterals(v: String, isFloat: Boolean): Any = {
+ val str = v.trim
+ if (str.equalsIgnoreCase("infinity") || str.equalsIgnoreCase("+infinity"))
{
Review comment:
Do you need Locale.ROOT here? it's a really obscure possibility, but "i" can
cause problems
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
