tgravescs commented on a change in pull request #25047: [SPARK-27371][CORE]
Support GPU-aware resources scheduling in Standalone
URL: https://github.com/apache/spark/pull/25047#discussion_r311781902
##########
File path: core/src/main/scala/org/apache/spark/deploy/master/Master.scala
##########
@@ -742,7 +792,9 @@ private[deploy] class Master(
while (numWorkersVisited < numWorkersAlive && !launched) {
val worker = shuffledAliveWorkers(curPos)
numWorkersVisited += 1
- if (worker.memoryFree >= driver.desc.mem && worker.coresFree >=
driver.desc.cores) {
+ if (canLaunchDriver(worker, driver.desc)) {
+ val allocated = worker.acquireResources(driver.desc.resourceReqs)
+ driver.withResources(allocated)
Review comment:
I'm assuming driver could also not launch if worker doesn't have any GPUs
and it requests them, may want to warn here as well
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
