rdblue commented on a change in pull request #25305: [SPARK-28572][SQL] Simple
analyzer checks for v2 table creation code paths
URL: https://github.com/apache/spark/pull/25305#discussion_r311809306
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
##########
@@ -1193,3 +1211,17 @@ case class Deduplicate(
override def output: Seq[Attribute] = child.output
}
+
+/** A trait used for logical plan nodes that create or replace V2 table
definitions. */
+sealed trait V2TableCreation extends LogicalPlan {
+ def tableName: Identifier
+ def partitioning: Seq[Transform]
+ def tableSchema: StructType
+
+ /**
+ * Creates a copy of this node with the new partitoning transforms. This
method is used to
+ * rewrite these nodes after normalizing the field references for these
transforms according to
+ * case sensitivity.
+ */
+ def withPartitioning(rewritten: Seq[Transform]): V2TableCreation
Review comment:
If I understand correctly, the intent is to normalize reference names to
names from the table schema?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
