dongjoon-hyun commented on a change in pull request #25385: optimization spark 
event log that resulting in history server is too …
URL: https://github.com/apache/spark/pull/25385#discussion_r311886091
 
 

 ##########
 File path: 
core/src/main/scala/org/apache/spark/scheduler/EventLoggingListener.scala
 ##########
 @@ -148,6 +152,59 @@ private[spark] class EventLoggingListener(
     }
   }
 
+  /** cut the event log file **/
+  private def logReload(): Unit = {
 
 Review comment:
   Is it consistent? This function name is `logReload` and the description is 
`cut the event log file`. It seems to be opposite (read vs write).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to