LuciferYang commented on a change in pull request #25309:
[SPARK-28577][YARN]Resource capability requested for each executor add
offHeapMemorySize
URL: https://github.com/apache/spark/pull/25309#discussion_r312009819
##########
File path:
resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/YarnSparkHadoopUtilSuite.scala
##########
@@ -140,4 +141,31 @@ class YarnSparkHadoopUtilSuite extends SparkFunSuite with
Matchers with Logging
}
}
+
+ test("executorOffHeapMemorySizeAsMb when MEMORY_OFFHEAP_ENABLED is false") {
+ val executorOffHeapMemory =
YarnSparkHadoopUtil.executorOffHeapMemorySizeAsMb(new SparkConf())
+ assert(executorOffHeapMemory == 0)
+ }
+
+ test("executorOffHeapMemorySizeAsMb when MEMORY_OFFHEAP_ENABLED is true") {
+ val offHeapMemoryInMB = 50
+ val offHeapMemory: Long = offHeapMemoryInMB * 1024 * 1024
+ val sparkConf = new SparkConf()
+ .set(MEMORY_OFFHEAP_ENABLED, true)
+ .set(MEMORY_OFFHEAP_SIZE, offHeapMemory)
+ val executorOffHeapMemory =
YarnSparkHadoopUtil.executorOffHeapMemorySizeAsMb(sparkConf)
+ assert(executorOffHeapMemory == offHeapMemoryInMB)
+ }
+
+ test("executorMemoryOverhead when MEMORY_OFFHEAP_ENABLED is true, " +
Review comment:
Add a new test suite `SPARK-28577#YarnAllocator.resource.memory should
include offHeapSize when offHeapEnabled is true.` in YarnAllocatorSuite
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
