wangyum commented on a change in pull request #23899:
[SPARK-26969][spark-thriftserver] Bigdecimal values shall be converted to
HiveDecimal type for succesful processing of query using ODBC interface
URL: https://github.com/apache/spark/pull/23899#discussion_r312019555
##########
File path:
sql/hive-thriftserver/v2.3.5/src/main/java/org/apache/hive/service/cli/ColumnValue.java
##########
@@ -199,7 +199,7 @@ public static TColumnValue toTColumnValue(TypeDescriptor
typeDescriptor, Object
case INTERVAL_DAY_TIME_TYPE:
return stringValue((HiveIntervalDayTime) value);
case DECIMAL_TYPE:
- return stringValue((HiveDecimal)value, typeDescriptor);
+ stringValue(((BigDecimal)value).toPlainString());
case BINARY_TYPE:
String strVal = value == null ? null :
UTF8String.fromBytes((byte[])value).toString();
Review comment:
Could you remove these lines:
https://github.com/apache/spark/pull/23899/files#diff-5aed8ed671b217c7920c373fc491869aL26
https://github.com/apache/spark/pull/23899/files#diff-5aed8ed671b217c7920c373fc491869aR144-R151
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
