MaxGekk commented on a change in pull request #25336: [SPARK-28017][SQL]
Support additional levels of truncations by DATE_TRUNC/TRUNC
URL: https://github.com/apache/spark/pull/25336#discussion_r312121856
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
##########
@@ -1471,14 +1471,24 @@ trait TruncInstant extends BinaryExpression with
ImplicitCastInputTypes {
@ExpressionDescription(
usage = """
_FUNC_(date, fmt) - Returns `date` with the time portion of the day
truncated to the unit specified by the format model `fmt`.
- `fmt` should be one of ["year", "yyyy", "yy", "mon", "month", "mm"]
+ `fmt` should be one of ["week", "mon", "month", "mm", "quarter", "year",
"yyyy", "yy", "decade", "century", "millennium"]
""",
examples = """
Examples:
+ > SELECT _FUNC_('2019-08-04', 'week');
+ 2019-07-29
+ > SELECT _FUNC_('2019-08-04', 'quarter');
+ 2019-07-01
> SELECT _FUNC_('2009-02-12', 'MM');
2009-02-01
> SELECT _FUNC_('2015-10-27', 'YEAR');
2015-01-01
+ > SELECT _FUNC_('2015-10-27', 'DECADE');
+ 2010-01-01
+ > SELECT _FUNC_('1981-01-19', 'century');
+ 1901-01-01
+ > SELECT _FUNC_('1981-01-19', 'millennium');
+ 1001-01-01
Review comment:
Century (and millennium as well) starts from the first year, see
https://en.wikipedia.org/wiki/Century#Viewpoint_1:_Strict_usage and
https://en.wikipedia.org/wiki/Millennium#Viewpoint_1:_Strict_usage . Decades
are calculated as PostgreSQL does which follows common practice:
https://en.wikipedia.org/wiki/List_of_decades
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
