xianyinxin commented on a change in pull request #25115: [SPARK-28351][SQL]
Support DELETE in DataSource V2
URL: https://github.com/apache/spark/pull/25115#discussion_r312372252
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##########
@@ -1761,6 +1761,8 @@ class Analyzer(
// Only a few unary nodes (Project/Filter/Aggregate) can contain
subqueries.
case q: UnaryNode if q.childrenResolved =>
resolveSubQueries(q, q.children)
+ case d: DeleteFromTable if d.childrenResolved =>
Review comment:
`UnaryNode` has a final `children` while there's a default override version
of `children` in `Command`, which is a problem. A `Command` is designed for
operators that has side-effects, so they can be executed eagerly. In this
sense, I'd prefer to keep `DeleteFromTable` a `Command`. What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
