pgandhi999 commented on a change in pull request #25397: [SPARK-28677][WEBUI]
"Select All" checkbox in StagePage doesn't work properly
URL: https://github.com/apache/spark/pull/25397#discussion_r312520734
##########
File path: core/src/main/resources/org/apache/spark/ui/static/stagepage.js
##########
@@ -897,7 +897,7 @@ $(document).ready(function () {
// Get the column
var para = $(this).attr('data-column');
if (para == "0") {
- var column = taskTableSelector.column(optionalColumns);
+ var column =
taskTableSelector.columns(optionalColumns);
Review comment:
NIT: Could you rename the variable to something like `allColumns` to have
more clarity?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
