gengliangwang commented on a change in pull request #25369:
[SPARK-28638][WebUI] Task summary should only contain successful tasks' metrics
URL: https://github.com/apache/spark/pull/25369#discussion_r312583562
##########
File path: core/src/main/scala/org/apache/spark/status/AppStatusStore.scala
##########
@@ -156,7 +162,8 @@ private[spark] class AppStatusStore(
// cheaper for disk stores (avoids deserialization).
val count = {
Utils.tryWithResource(
- if (store.isInstanceOf[InMemoryStore]) {
+ if (isInMemoryStore) {
Review comment:
@vanzin Got it. I have updated the title.
The PR itself is about mismatching the kvstore, and leading to the wrong
cache for task summary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
