Github user nchammas commented on a diff in the pull request:
https://github.com/apache/spark/pull/3988#discussion_r23237991
--- Diff: build/mvn ---
@@ -48,11 +48,11 @@ install_app() {
# check if we already have the tarball
# check if we have curl installed
# download application
- [ ! -f "${local_tarball}" ] && [ -n "`which curl 2>/dev/null`" ] && \
+ [ ! -f "${local_tarball}" ] && command -v curl &>/dev/null && \
--- End diff --
Instead of `&>/dev/null`, which seems a little confusing, can't we use
```
if [ $(command -v curl) ];
```
to test for the existence of `curl`?
We don't have to redirect output if we do it this way, and it's much more
readable. I suggest using this pattern throughout.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
