Udbhav30 commented on a change in pull request #25398: [SPARK-28659][SQL] Use
data source if convertible in insert overwrite directory
URL: https://github.com/apache/spark/pull/25398#discussion_r312723036
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala
##########
@@ -1396,6 +1396,17 @@ class SparkSqlAstBuilder(conf: SQLConf) extends
AstBuilder(conf) {
compressed = false,
properties = rowStorage.properties ++ fileStorage.properties)
- (ctx.LOCAL != null, storage, Some(DDLUtils.HIVE_PROVIDER))
+ val fileFormat = extractFileFormat(fileStorage.serde)
+ (ctx.LOCAL != null, storage, Some(fileFormat))
+ }
Review comment:
in case of `parquet` and `orc` we can use the respective file format instead
of `hive`.
In case of ctas also we convert to use data source
https://github.com/viirya/spark-1/blob/839a6ce1732fa37b5f8ec9afa2d51730fc6ca691/sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveStrategies.scala#L188
This will make it inline with that behavior.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
