Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/4091#discussion_r23245131
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -323,19 +323,20 @@ object BooleanSimplification extends
Rule[LogicalPlan] with PredicateHelper {
val lhsSet = splitDisjunctivePredicates(left).toSet
val rhsSet = splitDisjunctivePredicates(right).toSet
val common = lhsSet.intersect(rhsSet)
- val ldiff = lhsSet.diff(common)
- val rdiff = rhsSet.diff(common)
- if (ldiff.size == 0 || rdiff.size == 0) {
- // a && (a || b) => a
- common.reduce(Or)
+ if (common.isEmpty) {
--- End diff --
Yeah, the logic here is redundant. This `if` is suggested by @rxin as a
shortcut for the case no common factors can be found to save query planning
time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
