Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3943#discussion_r23246429
  
    --- Diff: 
yarn/src/test/scala/org/apache/spark/deploy/yarn/YarnSparkHadoopUtilSuite.scala 
---
    @@ -148,4 +151,25 @@ class YarnSparkHadoopUtilSuite extends FunSuite with 
Matchers with Logging {
         }
     
       }
    +
    +  test("test expandEnvironment result") {
    +    val target = Environment.PWD
    +    var expect = "$" + target
    --- End diff --
    
    I'd do this whole block like so:
    
        val expected = if ('$$' exists) ... else if (isWindows) ... else ...



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to