MaxGekk commented on a change in pull request #25408: [SPARK-28687][SQL]
Support `epoch`, `isoyear`, `milliseconds` and `microseconds` at `extract()`
URL: https://github.com/apache/spark/pull/25408#discussion_r312788776
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
##########
@@ -455,6 +456,22 @@ object DateTimeUtils {
(MICROSECONDS.toSeconds(localTimestamp(microsec, timeZone)) % 60).toInt
}
+ /**
+ * Returns seconds, including fractional parts, multiplied by 1000. The
timestamp
Review comment:
I asked why it is better because @dongjoon-hyun suggested to changed without
explanation. Now it is clear for me, and I would keep this as is without gaps.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
