PavithraRamachandran commented on a change in pull request #25394: 
[SPARK-28671][SQL]when a non exsistent permanent function is 
dropped,NoSuchPermanentFunctionException is thrown
URL: https://github.com/apache/spark/pull/25394#discussion_r312788912
 
 

 ##########
 File path: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
 ##########
 @@ -1114,7 +1114,7 @@ class SessionCatalog(
       }
       externalCatalog.dropFunction(db, name.funcName)
     } else if (!ignoreIfNotExists) {
-      throw new NoSuchFunctionException(db = db, func = identifier.toString)
+      throw new NoSuchPermanentFunctionException(db = db, func = 
identifier.toString)
 
 Review comment:
   **SPARK-14384** has removed the support of alter function., Later on alter 
function was added as part of **create or replace** function support 
(**SPARK-20383**). So when we use create or replace,  the same issue will not 
come as it creates a new a function if function dies not exist.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to