Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/4115#discussion_r23249926
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/WrapDynamic.scala
---
@@ -39,7 +39,8 @@ case class WrapDynamic(children: Seq[Attribute]) extends
Expression {
override def eval(input: Row): DynamicRow = input match {
// Avoid copy for generic rows.
case g: GenericRow => new DynamicRow(children, g.values)
- case otherRowType => new DynamicRow(children, otherRowType.toArray)
+ case otherRowType => new DynamicRow(children,
otherRowType.toSeq.toArray)
+ // TODO: toSeq.toArray is very slow!
--- End diff --
We might even just get rid of WrapDynamic
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
