advancedxy commented on a change in pull request #25398: [SPARK-28659][SQL] Use
data source if convertible in insert overwrite directory
URL: https://github.com/apache/spark/pull/25398#discussion_r312814580
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/sources/InsertSuite.scala
##########
@@ -441,7 +441,6 @@ class InsertSuite extends DataSourceTest with
SharedSQLContext {
sql(
s"""
|INSERT OVERWRITE LOCAL DIRECTORY '$path'
- |STORED AS orc
Review comment:
I believe the test case name should be modified correspondingly and a new
test case for (orc/parquet) should be added.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
