wangyum commented on a change in pull request #25417: [SPARK-28686][SQL][TEST]
Move udf_radians from HiveCompatibilitySuite to HiveQuerySuite
URL: https://github.com/apache/spark/pull/25417#discussion_r312829447
##########
File path:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala
##########
@@ -1207,6 +1208,22 @@ class HiveQuerySuite extends HiveComparisonTest with
SQLTestUtils with BeforeAnd
}
}
}
+
+ // This test case is moved from HiveCompatibilitySuite to make it easy to
test with JDK 11.
+ test("udf_radians") {
+ withSQLConf("hive.fetch.task.conversion" -> "more") {
+ val result = sql("select radians(57.2958) FROM src tablesample (1
rows)").collect()
+ if (SystemUtils.isJavaVersionAtLeast(JavaVersion.JAVA_9)) {
+ assertResult(Array(Row(1.0000003575641672))) (result)
+ } else {
+ assertResult(Array(Row(1.000000357564167))) (result)
+ }
Review comment:
Hive output result:
https://github.com/apache/hive/blob/release-2.3.5-rc0/ql/src/test/results/clientpositive/udf_radians.q.out#L87-L91
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
