cloud-fan commented on a change in pull request #24892: [SPARK-25341][Core] 
Support rolling back a shuffle map stage and re-generate the shuffle files
URL: https://github.com/apache/spark/pull/24892#discussion_r312907312
 
 

 ##########
 File path: 
common/network-shuffle/src/test/java/org/apache/spark/network/shuffle/ExternalShuffleIntegrationSuite.java
 ##########
 @@ -157,9 +158,20 @@ public void releaseBuffers() {
     }
   }
 
-  // Fetch a set of blocks from a pre-registered executor.
+  // Fetch a set of shuffle blocks with default generation id -1 from a 
pre-registered executor.
   private FetchResult fetchBlocks(String execId, String[] blockIds) throws 
Exception {
-    return fetchBlocks(execId, blockIds, conf, server.getPort());
+    return fetchBlocks(execId, blockIds, conf, server.getPort(), -1, true);
+  }
+
+  // Fetch a set of shuffle blocks from a pre-registered executor.
+  private FetchResult fetchBlocks(
 
 Review comment:
   ditto

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to