abellina commented on a change in pull request #25403: [SPARK-28679][YARN]
changes to setResourceInformation to handle empty resources and reflection
error handling
URL: https://github.com/apache/spark/pull/25403#discussion_r312910904
##########
File path:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/ResourceRequestHelper.scala
##########
@@ -153,7 +153,16 @@ private object ResourceRequestHelper extends Logging {
val resInfoClass = Utils.classForName(RESOURCE_INFO_CLASS)
val setResourceInformationMethod =
- resource.getClass.getMethod("setResourceInformation", classOf[String],
resInfoClass)
+ try {
+ resource.getClass.getMethod("setResourceInformation", classOf[String],
resInfoClass)
+ } catch {
+ case e: NoSuchMethodException =>
Review comment:
Good point. I can change to re-throw the exception, to make it obvious you
have an issue in your class path that needs to be addressed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
