gaborgsomogyi commented on a change in pull request #25412: [SPARK-28691][EXAMPLES] DirectKafkaWordCount support kafka with kerberos URL: https://github.com/apache/spark/pull/25412#discussion_r312955921
########## File path: examples/src/main/java/org/apache/spark/examples/streaming/JavaDirectKafkaWordCount.java ########## @@ -66,6 +78,10 @@ public static void main(String[] args) throws Exception { String brokers = args[0]; String groupId = args[1]; String topics = args[2]; + Boolean kerberosOn = false; + if (args.length > 3) { Review comment: Why optional? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org