squito commented on a change in pull request #25299: [SPARK-27651][Core] Avoid
the network when shuffle blocks are fetched from the same host
URL: https://github.com/apache/spark/pull/25299#discussion_r313069454
##########
File path:
core/src/test/scala/org/apache/spark/ExternalShuffleServiceSuite.scala
##########
@@ -67,7 +67,9 @@ class ExternalShuffleServiceSuite extends ShuffleSuite with
BeforeAndAfterAll wi
// This test ensures that the external shuffle service is actually in use
for the other tests.
test("using external shuffle service") {
- sc = new SparkContext("local-cluster[2,1,1024]", "test", conf)
+ val confWithoutHostLocalRead =
+ conf.clone.set(config.SHUFFLE_HOST_LOCAL_DISK_READING_ENABLED, false)
Review comment:
this test case makes me think that mayeb we should disable this
configuration just for local-cluster mode. That's a testing util intended to
feel a lot like a real cluster -- I think it would be good to still have it be
going over the network (unless the user explicitly sets it to true).
Makes the defaulting of this option a little more complex, but seems worth
it to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
