edgarRd commented on issue #25206: [SPARK-28265][SQL] Add renameTable to 
TableCatalog API
URL: https://github.com/apache/spark/pull/25206#issuecomment-520560594
 
 
   Thanks everyone for your input. I think it looks like we agree on the 
following points for this PR:
   1. The behavior of the catalog operation `renameTable`  is to change the 
table name, **including namespace**, defined by the table identifier from 
`oldIdentifier` to `newIdentifier`. 
   2. It’s up to the catalog implementation to support this operation or not. 
The `TableCatalog#renameTable` operation will throw an appropriate `Exception` 
based on the catalog specific implementation.
   3. Spark does not constrict the behavior to particularities in the 
underlying catalog, nor it aims to define how the catalog must implement this 
operation, e.g. table move, metadata change, directory relocation, etc.
   4. Rename table is only defined for tables within the same catalog.
   
   Based on the previous points, I’ve pushed the changes back to how I 
originally submitted this PR, where the catalog does not throw 
`AnalysisException` and instead the more general 
`UnsupportedOperationException` is optionally thrown.
   
   @rdblue @cloud-fan please let me know if there are any other concerns. Thank 
you.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to