dongjoon-hyun commented on a change in pull request #25419: [SPARK-28698][SQL]
Support user-specified output schema in `to_avro`
URL: https://github.com/apache/spark/pull/25419#discussion_r313088362
##########
File path:
external/avro/src/test/scala/org/apache/spark/sql/avro/AvroCatalystDataConversionSuite.scala
##########
@@ -38,12 +38,12 @@ class AvroCatalystDataConversionSuite extends SparkFunSuite
private def checkResult(data: Literal, schema: String, expected: Any): Unit
= {
checkEvaluation(
- AvroDataToCatalyst(CatalystDataToAvro(data), schema, Map.empty),
+ AvroDataToCatalyst(CatalystDataToAvro(data, None), schema, Map.empty),
prepareExpectedResult(expected))
}
protected def checkUnsupportedRead(data: Literal, schema: String): Unit = {
- val binary = CatalystDataToAvro(data)
+ val binary = CatalystDataToAvro(data, None)
Review comment:
Also, if we have the default value, we don't need to change line 41 and 46.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
