squito commented on a change in pull request #24970: [SPARK-23977][SQL] Support
High Performance S3A committers [test-hadoop3.2]
URL: https://github.com/apache/spark/pull/24970#discussion_r313098854
##########
File path:
core/src/main/scala/org/apache/spark/internal/io/HadoopMapReduceCommitProtocol.scala
##########
@@ -205,11 +206,28 @@ class HadoopMapReduceCommitProtocol(
}
}
+ /**
+ * Abort the job; log and ignore any IO exception thrown.
+ * This is invariably invoked in an exception handler; raising
+ * an exception here will lose the root cause of the failure.
Review comment:
you are right about this -- exceptions from here would mess up
`SparkHadoopWriter` and `FileFormatWriter`. But isn't the right thing to do
for those to catch the errors and use `originalException.addSuppressed` as is
done in `WriteToDataSourceV2Exec`?
https://github.com/apache/spark/blob/48d04f74ca895497b9d8bab18c7708f76f55c520/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/WriteToDataSourceV2Exec.scala#L388-L393
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
