viirya commented on a change in pull request #20826: [Spark-2489][SQL]
Unsupported parquet datatype optional fixed_len_byte_array
URL: https://github.com/apache/spark/pull/20826#discussion_r313136544
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetAvroCompatibilitySuite.scala
##########
@@ -62,12 +70,12 @@ class ParquetAvroCompatibilitySuite extends
ParquetCompatibilityTest with Shared
.setDoubleColumn(i.toDouble + 0.2d)
.setBinaryColumn(ByteBuffer.wrap(s"val_$i".getBytes(StandardCharsets.UTF_8)))
.setStringColumn(s"val_$i")
+ .setFixedColumn(new FixedType(generateFixedLengthByteArray(i)))
.build())
}
}
logParquetSchema(path)
-
checkAnswer(spark.read.parquet(path), (0 until 10).map { i =>
Review comment:
I think this only tests against `spark.sql.parquet.enableVectorizedReader`
is true (default), should we test non-vectorized reader too?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
