cloud-fan commented on a change in pull request #25418: [SPARK-28695][SS] Use
CaseInsensitiveMap in KafkaSourceProvider to make source param handling more
robust
URL: https://github.com/apache/spark/pull/25418#discussion_r313347432
##########
File path:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSourceProvider.scala
##########
@@ -307,14 +317,14 @@ private[kafka010] class KafkaSourceProvider extends
DataSourceRegister
}
}
- private def validateStreamOptions(caseInsensitiveParams: Map[String,
String]) = {
+ private def validateStreamOptions(caseInsensitiveParams:
CaseInsensitiveMap[String]) = {
// Stream specific options
caseInsensitiveParams.get(ENDING_OFFSETS_OPTION_KEY).map(_ =>
throw new IllegalArgumentException("ending offset not valid in streaming
queries"))
validateGeneralOptions(caseInsensitiveParams)
}
- private def validateBatchOptions(caseInsensitiveParams: Map[String, String])
= {
+ private def validateBatchOptions(caseInsensitiveParams:
CaseInsensitiveMap[String]) = {
Review comment:
maybe we can rename the parameter name to `params`, as we can easily tell
it's case insensitive by the type.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
