dongjoon-hyun commented on a change in pull request #25429: [SPARK-28708][SQL]
IsolatedClientLoader will not load hive classes from application jars on JDK9+
URL: https://github.com/apache/spark/pull/25429#discussion_r313460910
##########
File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveUtils.scala
##########
@@ -338,18 +338,20 @@ private[spark] object HiveUtils extends Logging {
}
val classLoader = Utils.getContextOrSparkClassLoader
- val jars = allJars(classLoader)
- if (SystemUtils.isJavaVersionAtLeast(JavaVersion.JAVA_9)) {
+ val jars: Array[URL] = if
(SystemUtils.isJavaVersionAtLeast(JavaVersion.JAVA_9)) {
// Do nothing. The system classloader is no longer a URLClassLoader in
Java 9,
// so it won't match the case in allJars above. It no longer exposes
URLs of
Review comment:
+1 for removing `above` from `allJars above`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
