dongjoon-hyun commented on a change in pull request #25427:
[SPARK-28705][Test]drop table after being used
URL: https://github.com/apache/spark/pull/25427#discussion_r313543111
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisExternalCatalogSuite.scala
##########
@@ -57,6 +57,7 @@ class AnalysisExternalCatalogSuite extends AnalysisTest with
Matchers {
val plan = Project(Seq(func), testRelation)
analyzer.execute(plan)
verifyZeroInteractions(catalog)
+ catalog.dropTable("default", "t1", true, false)
Review comment:
In that case, this cannot guarantee what you want. This test can fail at
line 59.
I'd like to recommend to you clean up the leftovers at `def afterAll`.
Please refer the other test case which is overriding `afterAll` function. That
will be the recommended and more robust way to do this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
