voidbag commented on a change in pull request #24779: [SPARK-27929][SQL] Make
percentile function receive frq of double
URL: https://github.com/apache/spark/pull/24779#discussion_r313559109
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Percentile.scala
##########
@@ -67,16 +67,23 @@ case class Percentile(
child: Expression,
percentageExpression: Expression,
frequencyExpression : Expression,
+ isIntFreqExpression: Expression,
Review comment:
At first, I already implemented it only with NumericType, as you said.
But my first implementation wasn't compatible with hive(hive unittest had
failed).
I had found the existing IntegralType implementation which is compatible
with hive is only for integer, not rational number.
I couldn't find the way to resolve the problem without additional
parameter...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
