Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/4103#discussion_r23270994
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/configuration/BoostingStrategy.scala
---
@@ -88,4 +88,25 @@ object BoostingStrategy {
throw new IllegalArgumentException(s"$algo is not supported by
boosting.")
}
}
+
+ /**
+ * Returns default configuration for the boosting algorithm
+ * @param algo Learning goal. Supported:
+ *
[[org.apache.spark.mllib.tree.configuration.Algo.Classification]],
+ *
[[org.apache.spark.mllib.tree.configuration.Algo.Regression]]
+ * @return Configuration for boosting algorithm
+ */
+ def defaultParams(algo: Algo): BoostingStrategy = {
--- End diff --
Can we update the `defaultParams(algoStr: String)` to use the
implementation here instead of maintaining two copies.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
