xianyinxin commented on a change in pull request #25115: [SPARK-28351][SQL]
Support DELETE in DataSource V2
URL: https://github.com/apache/spark/pull/25115#discussion_r313679873
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceResolution.scala
##########
@@ -173,6 +173,19 @@ case class DataSourceResolution(
// only top-level adds are supported using AlterTableAddColumnsCommand
AlterTableAddColumnsCommand(table, newColumns.map(convertToStructField))
+ case DeleteFromStatement(AsTableIdentifier(table), tableAlias, condition)
=>
+ throw new AnalysisException(
Review comment:
Okay, I rolled back the resolve rules for `DeleteFromTable` as it was as
@cloud-fan suggested. For cases that like deleting from formats or
`V2SessionCatalog` support, let's open another pr. And another pr for resolve
rules is also need because I found other issues related with that. Does this
sounds reasonable?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
