brkyvz commented on a change in pull request #25368: [SPARK-28635][SQL] create
CatalogManager to track registered v2 catalogs
URL: https://github.com/apache/spark/pull/25368#discussion_r313697462
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceResolution.scala
##########
@@ -45,8 +45,8 @@ case class DataSourceResolution(
import org.apache.spark.sql.catalog.v2.CatalogV2Implicits._
import lookup._
- lazy val v2SessionCatalog: CatalogPlugin = lookup.sessionCatalog
- .getOrElse(throw new AnalysisException("No v2 session catalog
implementation is available"))
+ def v2SessionCatalog: CatalogPlugin = lookup.sessionCatalog
Review comment:
Shouldn't this rule just get the `CatalogManager` as an input instead of
`LookupCatalog`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
