brkyvz commented on a change in pull request #25402: [SPARK-28666] Support
saveAsTable for V2 tables through Session Catalog
URL: https://github.com/apache/spark/pull/25402#discussion_r313703668
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/sources/v2/DataSourceV2SQLSuite.scala
##########
@@ -493,8 +494,12 @@ class DataSourceV2SQLSuite extends QueryTest with
SharedSQLContext with BeforeAn
sparkSession.sql(s"CREATE TABLE table_name USING parquet AS SELECT id,
data FROM source")
- // use the catalog name to force loading with the v2 catalog
- checkAnswer(sparkSession.sql(s"TABLE session.table_name"),
sparkSession.table("source"))
+ checkAnswer(sparkSession.sql(s"TABLE default.table_name"),
sparkSession.table("source"))
Review comment:
We can maintain this behavior, but I'd rather not, as the V2SessionCatalog
can't properly handle views and such
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
