choojoyq commented on a change in pull request #25439: [SPARK-28709][DSTREAMS]
- Fix StreamingContext leak through Streaming…
URL: https://github.com/apache/spark/pull/25439#discussion_r313720790
##########
File path:
streaming/src/main/scala/org/apache/spark/streaming/StreamingContext.scala
##########
@@ -575,6 +577,8 @@ class StreamingContext private[streaming] (
try {
validate()
+ registerProgressListener()
Review comment:
I think so. I believe``StreamingTab`` shouldn't be responsible for
registering/unregistering the listener as it could be and even already used in
other place (metrics). Moreover seems there is also a bug that if ui is
disabled, listener isn't registered and metrics aren't reported.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
