maropu commented on a change in pull request #25408: [SPARK-28687][SQL] Support
`epoch`, `isoyear`, `milliseconds` and `microseconds` at `extract()`
URL: https://github.com/apache/spark/pull/25408#discussion_r313749588
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
##########
@@ -1426,6 +1428,12 @@ class AstBuilder(conf: SQLConf) extends
SqlBaseBaseVisitor[AnyRef] with Logging
Minute(expression(ctx.source))
case "SECOND" =>
Second(expression(ctx.source))
+ case "MILLISECONDS" | "MSEC" =>
Review comment:
I've checked the related code in pgsql and it seems to have many variants:
- millisecon
- ms
- msec
- mseconds
- msecs
- msecond
The implementation of `extract` is `timestamp_part` in pgsql:
https://github.com/postgres/postgres/blob/master/src/backend/utils/adt/timestamp.c#L4507
This function handles `DTK_MILLISEC ` for milleseconds:
https://github.com/postgres/postgres/blob/fded4773eb60541c6e7dbcf09c9bcb1cd36a063b/src/backend/utils/adt/timestamp.c#L4552
`DTK_MILLISEC ` is expanded into many variants above:
https://github.com/postgres/postgres/blob/fded4773eb60541c6e7dbcf09c9bcb1cd36a063b/src/interfaces/ecpg/pgtypeslib/dt_common.c#L446
https://github.com/postgres/postgres/blob/fded4773eb60541c6e7dbcf09c9bcb1cd36a063b/src/include/utils/datetime.h#L49
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
