Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/2847#issuecomment-70773748
@jackylk I made a brief scan of the implementation. Besides inline
comments, I have some high-level suggestions:
1) It would be good if we can make the code easier for someone with the
paper in hand. I don't think the notation is good in the PFP paper. But when we
create a variable, we should put a comment mentioning the corresponding
variable name in the paper.
2) Maybe for reason 1), I cannot find an exact match between the
implementation and the algorithm described in the paper. It seems that you
implemented `Figure 1` of the paper but it is not the PFP algorithm. Could you
double check?
3) The tree building code needs some unit tests. So it is easy to convince
reviewers that the implementation is correct. And if using trees can compress
the data, we should use aggregateByKey instead of groupByKey.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
