wangyum commented on a change in pull request #25443: 
[WIP][SPARK-28723][test-hadoop3.2][test-maven] Test JDK 11 with Hadoop-3.2/Hive 
2.3.6 on jenkins
URL: https://github.com/apache/spark/pull/25443#discussion_r313880183
 
 

 ##########
 File path: python/pyspark/ml/tests/test_algorithms.py
 ##########
 @@ -86,7 +86,7 @@ def test_raw_and_probability_prediction(self):
         expected_rawPrediction = [-11.6081922998, -8.15827998691, 22.17757045]
         self.assertTrue(result.prediction, expected_prediction)
         self.assertTrue(np.allclose(result.probability, expected_probability, 
atol=1E-4))
-        self.assertTrue(np.allclose(result.rawPrediction, 
expected_rawPrediction, atol=1E-4))
+        # self.assertTrue(np.allclose(result.rawPrediction, 
expected_rawPrediction, atol=1E-4))
 
 Review comment:
   @HyukjinKwon This test will fail:
   ```
   ======================================================================
   FAIL: test_raw_and_probability_prediction 
(pyspark.ml.tests.test_algorithms.MultilayerPerceptronClassifierTest)
   ----------------------------------------------------------------------
   Traceback (most recent call last):
     File 
"/home/jenkins/workspace/SparkPullRequestBuilder/python/pyspark/ml/tests/test_algorithms.py",
 line 89, in test_raw_and_probability_prediction
       self.assertTrue(np.allclose(result.rawPrediction, 
expected_rawPrediction, atol=1E-4))
   AssertionError: False is not true
   
   ----------------------------------------------------------------------
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to