srowen commented on a change in pull request #25443:
[WIP][SPARK-28723][test-hadoop3.2][test-maven] Test JDK 11 with Hadoop-3.2/Hive
2.3.6 on jenkins
URL: https://github.com/apache/spark/pull/25443#discussion_r313880550
##########
File path: dev/run-tests-jenkins.py
##########
@@ -183,6 +183,7 @@ def main():
os.environ["AMPLAB_JENKINS_BUILD_PROFILE"] = "hadoop2.7"
if "test-hadoop3.2" in ghprb_pull_title:
os.environ["AMPLAB_JENKINS_BUILD_PROFILE"] = "hadoop3.2"
+ os.environ["JAVA_HOME"] = "/usr/java/jdk-11.0.1"
Review comment:
Let's perhaps look separately for `test-java11` as in
https://github.com/apache/spark/pull/25423 so we can separate these concerns?
So let's see this script only runs tests, so yes it should set JAVA_HOME
this way when testing Java 11. I think `dev/run-tests` has to change too, to
set `-Djava.version=11` to Maven and SBT when testing Java 11 too. Can we try
that here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
