wangyum commented on a change in pull request #22502: [SPARK-25474][SQL]
Support `spark.sql.statistics.fallBackToHdfs` in data source tables
URL: https://github.com/apache/spark/pull/22502#discussion_r313950260
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/HadoopFsRelation.scala
##########
@@ -71,7 +70,13 @@ case class HadoopFsRelation(
override def sizeInBytes: Long = {
val compressionFactor = sqlContext.conf.fileCompressionFactor
- (location.sizeInBytes * compressionFactor).toLong
+ val defaultSize = (location.sizeInBytes * compressionFactor).toLong
+ location match {
+ case cfi: CatalogFileIndex if
sparkSession.sessionState.conf.fallBackToHdfsForStatsEnabled =>
Review comment:
I think `(location.sizeInBytes * compressionFactor).toLong` is enough.
And `(location.sizeInBytes * compressionFactor).toLong` is faster than
`CommandUtils.getSizeInBytesFallBackToHdfs(sparkSession, new
Path(cfi.table.location), defaultSize)`.
That why I only recalculate table statistics if we go this code path:
https://github.com/apache/spark/blob/c30b5297bc607ae33cc2fcf624b127942154e559/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala#L383-L387
https://github.com/apache/spark/pull/24715/files#diff-d99813bd5bbc18277e4090475e4944cfR643-R646
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
